fix: chunk down flag assigned to not hit the max grpc limit #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
force-pushed
the
chunk-flag-assigned
branch
from
b2b7b72 to
f7395c5
Compare
nicklasl
reviewed
Oct 13, 2025
| } | ||
|
|
||
| @Override | ||
| public void write(WriteFlagLogsRequest request) { |
Member
There was a problem hiding this comment.
Given that this now contains a lot more logic I think we should write tests for it.
nicklasl
reviewed
Oct 13, 2025
openfeature-provider-local/src/main/java/com/spotify/confidence/GrpcWasmFlagLogger.java
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Oct 13, 2025
openfeature-provider-local/src/main/java/com/spotify/confidence/GrpcWasmFlagLogger.java
Show resolved
Hide resolved
nicklasl
reviewed
Oct 13, 2025
openfeature-provider-local/src/main/java/com/spotify/confidence/GrpcWasmFlagLogger.java
Show resolved
Hide resolved
vahidlazio
force-pushed
the
chunk-flag-assigned
branch
from
125b1f0 to
987531b
Compare
nicklasl
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.